ModelCreator: check early if model exists #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ModelCreator.create, we now perform an initial check to see if the model name is already taken. This prevents long feedback cycles where otherwise the code will first upload a dataset and wait for validation only to fail later on because the model name is already used. Closes #60.
Mark TestEndToEnd as relevant for #60
We postponed our internal cleanup by a few weeks, so let's bring back the system tests in the meantime so that we can release.
Coveralls complained about line coverage being too low.
karthikmswamy
approved these changes
Aug 4, 2020
Contributor
karthikmswamy
left a comment
karthikmswamy
left a comment
There was a problem hiding this comment.
This would be a really useful feature. Thanks for adding this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ModelCreator.create, we now perform an initial check
to see if the model name is already taken. This prevents
long feedback cycles where otherwise the code will first upload
a dataset and wait for validation only to fail later on because
the model name is already used.